Add back support for DockerfileGitCommitSha variable#1617
Merged
lbussell merged 3 commits intodotnet:mainfrom Mar 4, 2025
Merged
Add back support for DockerfileGitCommitSha variable#1617lbussell merged 3 commits intodotnet:mainfrom
lbussell merged 3 commits intodotnet:mainfrom
Conversation
…m variables (dotnet#1399)" This reverts commit df4c6ca.
Member
Deferring to @mthalman and @lbussell as they are the current maintainers of the repo. |
lbussell
reviewed
Mar 4, 2025
src/Microsoft.DotNet.ImageBuilder/src/ViewModel/VariableHelper.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Mar 4, 2025
lbussell
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to use this for dotnet/dotnet-buildtools-prereqs-docker#1375.
@MichaelSimons PTAL